Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Highlight active project when opening workflow in new canvas #12664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexgrozav
Copy link
Member

Summary

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-333/new-canvas-inconsistent-behavior

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/editor-ui/src/stores/workflows.store.ts 50.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jan 17, 2025

n8n    Run #8796

Run Properties:  status check failed Failed #8796  •  git commit 643d7cf76d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-333-new-canvas-inconsistent-behavior
Run status status check failed Failed #8796
Run duration 05m 55s
Commit git commit 643d7cf76d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 10
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 2
Tests that passed  Passing 360
View all changes introduced in this branch ↗︎

Tests for review

Failed  12-canvas.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Canvas Node Manipulation and Navigation > should add merge node and test connections Test Replay Screenshots Video
Canvas Node Manipulation and Navigation > should preserve connections after rename & node-view switch Test Replay Screenshots Video
Failed  17-sharing.cy.ts • 3 failed tests

View Output Video

Test Artifacts
Sharing > should open W1, add node using C2 as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U2 Test Replay Screenshots Video
Sharing > should have access to W1, W2, as U1 Test Replay Screenshots Video
Failed  39-projects.cy.ts • 3 failed tests

View Output Video

Test Artifacts
Projects > when starting from scratch > should filter credentials by project ID when creating new workflow or hard reloading an opened workflow Test Replay Screenshots Video
Projects > when starting from scratch > should allow to change inaccessible credential when the workflow was moved to a team project Test Replay Screenshots Video
Projects > when starting from scratch > should handle viewer role Test Replay Screenshots Video
Failed  30-editor-after-route-changes.cy.ts • 1 failed test

View Output Video

Test Artifacts
Editor zoom should work after route changes > after switching between Editor and Workflow history and Workflow list Test Replay Screenshots Video
Failed  48-subworkflow-inputs.cy.ts • 1 failed test

View Output Video

Test Artifacts
Sub-workflow creation and typed usage > works with type-checked values Test Replay Screenshots Video

The first 5 failed specs are shown, see all 44 specs in Cypress Cloud.

Flakiness  e2e/12-canvas-actions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Actions > Node hover actions > should execute node Test Replay Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants