Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(API): Add styling to credential callback and autoclose window #12648

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dana-gill
Copy link
Contributor

Summary

Add styling to credential callback and autoclose window. This looks more professional and also is a small reward for users setting up credentials

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1514/google-oauth-confirmation-modal-re-add-auto-close

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@dana-gill dana-gill marked this pull request as ready for review January 16, 2025 16:31
@dana-gill dana-gill changed the title Add styling to credential callback and autoclose window chore(): Add styling to credential callback and autoclose window Jan 16, 2025
@dana-gill dana-gill changed the title chore(): Add styling to credential callback and autoclose window chore(api): Add styling to credential callback and autoclose window Jan 16, 2025
@dana-gill dana-gill changed the title chore(api): Add styling to credential callback and autoclose window chore(API): Add styling to credential callback and autoclose window Jan 16, 2025
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 16, 2025
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Asked for design review before merging

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Due to the nature of rendering handlebar files, it's a bit of a
challenge to incorporate custom font styles. Hence, we are using
sans-serif
@dana-gill dana-gill force-pushed the node-1514-google-oauth-confirmation-modal-re-add-auto-close branch from 23a7866 to 0472fde Compare January 17, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants