Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update e2e tests for canvas specific actions (no-changelog) #12614

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

test: Update e2e tests for canvas specific actions (no-changelog) #12614

wants to merge 8 commits into from

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Jan 15, 2025 •
edited
Loading

Summary

image
  • Unknown nodes test is expected to fail until further notice
  • Checked that this Test suite passes without issues using old canvas after changes

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-525/12-canvas

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Jan 15, 2025
@alexgrozav alexgrozav changed the title test: Update e2e tests for canvas specific actions test: Update e2e tests for canvas specific actions (no-changelog) Jan 15, 2025
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 15, 2025
OlegIvaniv
OlegIvaniv reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaay, it drags! :D Great job, just a small nitpick

cypress/support/commands.ts
cy.get(draggableSelector).trigger('mousedown');
cy.ifCanvasVersion(
() => {
// We can't use realMouseDown here because it hangs headless run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this comment is no longer relevant. At least locally realMouseDown no longer hangs the tests. So perhaps we could simplify this by always using it?

@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...itor-ui/src/components/ContextMenu/ContextMenu.vue 0.00% 3 Missing ⚠️
...nents/canvas/elements/nodes/CanvasNodeRenderer.vue 88.88% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

OlegIvaniv
OlegIvaniv previously approved these changes Jan 16, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Jan 16, 2025 •
edited
Loading

n8n    Run #8819

Run Properties:  status check failed Failed #8819  •  git commit d712c7fecb: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-525-12-canvas
Run status status check failed Failed #8819
Run duration 05m 53s
Commit git commit d712c7fecb: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎
Test results
Tests that failed  Failures 5
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 413
View all changes introduced in this branch ↗︎

Tests for review

Failed  30-editor-after-route-changes.cy.ts • 3 failed tests

View Output Video

Test Artifacts
Editor actions should work > after switching between Editor and Executions Test Replay Screenshots Video
Editor actions should work > after switching between Editor and Debug Test Replay Screenshots Video
Editor actions should work > after switching between Editor and Workflow history Test Replay Screenshots Video
Failed  47-subworkflow-debugging.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Subworkflow debugging > can inspect parent executions Test Replay Screenshots Video
Subworkflow debugging > can inspect sub executed workflow > (Run once with all items/ Wait for Sub-workflow completion) (default behavior) Test Replay Screenshots Video
Failed  33-settings-personal.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  29-templates.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  16-form-trigger-node.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 30 specs in Cypress Cloud.

Flakiness  e2e/7-workflow-actions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Workflow Actions > should not save workflow if canvas is loading Test Replay Screenshots Video

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegIvaniv OlegIvaniv OlegIvaniv approved these changes

Assignees

@alexgrozav alexgrozav

Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexgrozav @OlegIvaniv