Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Telegram Trigger Node): Extend Telegram triggers list with all possible options #12591

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

olegtsvetkov
Copy link

Summary

Telegram API supports more updates for bots, than can be defined in N8N Telegram Trigger.

API docs: https://core.telegram.org/bots/api#update

Most of them can be received when using * option. But this produces extra calls of workflows. Users who pay per execution may pay for updates they don't need.

Also there are 3 updates, that can't be received at all due to the way Telegram API works: message_reaction, message_reaction_count and chat_member. They are excluded when setting up a web hook with allowed_updates: [] (see Description column in docs https://core.telegram.org/bots/api#setwebhook).

So currently it looks like this:

Telegram Update Support in N8N Telegram Trigger
message
edited_message
channel_post
edited_channel_post
business_connection only when using * option
business_message only when using * option
edited_business_message only when using * option
deleted_business_messages only when using * option
message_reaction ❌ not supported by N8N, excluded by Telegram from * option
message_reaction_count ❌ not supported by N8N, excluded by Telegram from * option
inline_query
chosen_inline_result only when using * option
callback_query
shipping_query
pre_checkout_query
purchased_paid_media only when using * option
poll
poll_answer only when using * option
my_chat_member only when using * option
chat_member ❌ not supported by N8N, excluded by Telegram from * option
chat_join_request only when using * option
chat_boost only when using * option
removed_chat_boost only when using * option

This MR adds support for all update options to Telegram Trigger Node for granular selection.

But preserves the backward compatibility:

  • Non of currently supported Updates was deleted
  • *option works the same, so users won't receive extra traffic to there workflows

Related Linear tickets, Github issues, and Community forum posts

There was an attempt to do something similar in May 2024, but it would cause an extra traffic to existing workflows: #9321

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2025

CLA assistant check
All committers have signed the CLA.

@olegtsvetkov olegtsvetkov changed the title feat(Telegram Node): Extend Telegram triggers list with all possible options feat(Telegram Trigger Node): Extend Telegram triggers list with all possible options Jan 13, 2025
@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Jan 13, 2025
@Joffcom
Copy link
Member

Joffcom commented Jan 13, 2025

Hey @olegtsvetkov,

Thanks for the PR, We have created "GHC-624" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants