Open
Conversation
Use a git dep for now since noq is not yet published.
Currently failing
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/116/docs/net_tools/ Last updated: 2026-03-11T11:34:04Z |
11 tasks
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Mar 12, 2026
## Description Remove netdev from direct dependencies. We still have it as an indirect dependency via netwatch for now. The plan is to replace some functionality in net-tools with stubs to remove the netdev dependency that does not work on esp32. See n0-computer/net-tools#116 ipnet is not a new dep, just a new direct dep. We had it before via netwatch. ## Breaking Changes None ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist <!-- Remove any that are not relevant. --> - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented. - [ ] List all breaking changes in the above "Breaking Changes" section. - [ ] Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are: - [ ] [`quic-rpc`](https://github.com/n0-computer/quic-rpc) - [ ] [`iroh-gossip`](https://github.com/n0-computer/iroh-gossip) - [ ] [`iroh-blobs`](https://github.com/n0-computer/iroh-blobs) - [ ] [`dumbpipe`](https://github.com/n0-computer/dumbpipe) - [ ] [`sendme`](https://github.com/n0-computer/sendme)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds esp32 support and CI
Breaking Changes
None
Notes & open questions
Note: the posix_minimal impl for now just adds stubs that don't do nothing whatsoever, which works fine for esp32. We could and should add a poll based simple implementation later, but maybe not in this PR.
I got a WIP PR here: #117, but still need to thoroughly check it.
Change checklist