Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/104/docs/net_tools/ Last updated: 2026-03-04T09:15:26Z |
929cb96 to
f30876c
Compare
|
Can I interest you in a pub struct WithTimestamp<T> {
#[deref_mut]
inner: T,
last_updated: Instant,
}? |
matheus23
left a comment
There was a problem hiding this comment.
I still don't like how this PR duplicates Eq partially. It seems error-prone to me.
I have another proposal for how to fix this, instead of a last_updated timestamp, how about a last_unsuspend_detected: Instant? I think this would make the whole logic a lot cleaner and might even help consumers of this API understand if they need to/want to handle such changes, unlike mysteriously having the last_updated changing without any actual changes.
|
how/when would this be set? |
|
In the netmon actor, in check_wall_time_advance() |
f30876c to
ae976c4
Compare
|
@matheus23 updated |
Based on #103