Repository navigation
feat(iroh)!: expose batch datagram send/recv APIs - #4547
Merged
Merged
Conversation
Add thin passthroughs to the underlying noq batch APIs so downstream crates (e.g. rayfish) can amortize the per-datagram connection-mutex cost, which is the dominant overhead at high pps for a mesh VPN forwarding bursts of TUN packets. - Connection::send_datagrams / read_datagrams delegate to noq::Connection. - Re-export ReadDatagrams and SendMany through endpoint::quic and the public endpoint surface (required by the crate's unreachable_pub lint). - Add [patch.crates-io] pointing noq/noq-proto/noq-udp at the local fork (../noq) so iroh builds against the rayfish noq with the batch APIs. This is a workspace-local dev override; published iroh still resolves to noq 1.0.1 from crates.io.
Follow the noq rename to read_many_datagrams / send_many_datagrams and the slice-based signatures.
# Conflicts: # Cargo.lock # Cargo.toml
3 of 4 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4547/docs/iroh/ Last updated: 2026-09-24T23:51:59Z |
Contributor
|
LGTM |
ramfox
force-pushed
the
ifdario/datagram_batching
branch
from
September 24, 2026 23:50
b3935f0 to
e1a9c3f
Compare
Collaborator
oops... |
flub
reviewed
Sep 29, 2026
| //! to limit or expand how those structs are used in iroh. By encapsulating them | ||
| //! we can ensure the functionality needed to make iroh work. | ||
|
|
||
| use std::{path::Path, sync::Arc, time::Duration}; |
Collaborator
There was a problem hiding this comment.
what happened here? If Path is needed unconditionally then why is the cfg left blank below. What does the cfg actually apply to now?
gsnaiper
pushed a commit
to gsnaiper/iroh
that referenced
this pull request
Oct 8, 2026
Expose the new `noq` batch datagram APIs through iroh's `Connection`. Downstream crates can amortize the per-datagram connection-mutex cost, which is the dominant overhead at high PPS for a mesh VPN forwarding bursts of TUN packets. `Connection::send_many_datagrams` and `Connection::read_many_datagrams` delegate to `noq::Connection`. Re-export `ReadManyDatagrams` through `endpoint::quic` to ensure we have no unreachable structs in our public API. Co-authored-by: Dario <dario@rayfish.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirroring PR #4383
We want this PR merged but the original author is not responding to comments. @ifdario's commits and contributions have been preserved.
This description needs to be updated before merging.
Description
Expose the new noq batch datagram APIs through iroh's
Connectionwrapper so downstream crates (e.g. rayfish) can amortize the per-datagram connection-mutex cost, which is the dominant overhead at high pps for a mesh VPN forwarding bursts of TUN packets.Connection::send_datagrams/read_datagramsdelegate tonoq::Connection.ReadDatagramsandSendManythroughendpoint::quicand the public endpoint surface (required by the crate'sunreachable_publint).Depends on the noq PR that adds
Connection::send_datagrams/read_datagramsandDatagramState::recv_many/Datagrams::send_many. This branch should not merge until that noq release is published and the[patch.crates-io]override (see below) is removed.Breaking Changes
None. All additions are additive methods and types. Existing
send_datagram/read_datagram/send_datagram_waitare unchanged.Notes & open questions
[patch.crates-io]override in the workspaceCargo.tomlpointingnoq/noq-proto/noq-udpat a local fork (../noq) so iroh can see the new APIs during development. This MUST be removed before merge, which requires the noq batch-API PR to be merged and a new noq release published to crates.io first. Leaving the patch in would break CI for anyone without the local../noqcheckout.iroh/Cargo.tomlis not yet bumped; a follow-up commit will bumpnoq(andnoq-proto/noq-udp) to the released version that contains the batch APIs, and remove the patch, in the same change.Change checklist