Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds endpoint-wide configuration for the number and buffered size of pending incoming connection attempts.
max_incoming,incoming_buffer_size, andincoming_buffer_size_totaltoEndpoint::Builder.noqdefaults when the methods are not called.Endpoint::set_alpns().ServerConfigBuildersettings cannot affect anIncomingthat already exists.Closes #4545
API Changes
This adds three non-breaking fluent builder methods:
The methods mirror the existing settings on
ServerConfigBuilder, using the non-set_naming convention already used byEndpoint::Builder. Existing behavior and defaults are unchanged.Notes & open questions
The implementation stores optional overrides rather than duplicating
noq's default values, so future default changes continue to flow through when applications do not configure these limits.Testing
cargo test --locked -p iroh --lib— 125 passed, 1 ignored.cargo test --locked -p iroh --all-features --lib— 131 passed, 1 ignored.cargo fmt --all --check -- --config unstable_features=true --config imports_granularity=Crate,group_imports=StdExternalCrate,reorder_imports=true,format_code_in_doc_comments=true.RUSTFLAGS=-Dwarnings cargo clippy --locked --workspace --all-features --all-targets --lib --bins --tests --benches --examples.RUSTFLAGS=-Dwarnings cargo clippy --locked --workspace --no-default-features --all-targets --lib --bins --tests --benches --examples.RUSTFLAGS=-Dwarnings cargo clippy --locked --workspace --all-targets --lib --bins --tests --benches --examples.RUSTDOCFLAGS=-Dwarnings cargo doc --locked --workspace --all-features --no-deps --document-private-items.git diff --check.Change checklist
proposed change and wrote an as clear and concise description as
they could.
intented effect.