Repository navigation
feat(metrics): lookup/resolver stats - #4543
Merged
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4543/docs/iroh/ Last updated: 2026-09-28T08:00:31Z |
Frando
force-pushed
the
Frando/resolver_metrics
branch
from
September 25, 2026 07:23
58cb300 to
f8477f7
Compare
## Description Adds counters to track lookup success rates and also tracks it by type of resolver. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist <!-- Remove any that are not relevant. --> - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] Tests if relevant. - [x] All breaking changes documented. - [x] This PR was created by a human that thought critically about the proposed change and wrote an as clear and concise description as they could. - [x] This PR isn't slop, and is carefully crafted to do have the intented effect.
Frando
force-pushed
the
Frando/resolver_metrics
branch
from
September 25, 2026 07:23
f8477f7 to
e675e31
Compare
matheus23
approved these changes
Sep 25, 2026
| type_associated_const_marked_deprecated = { required-update = "minor" } | ||
| type_marked_deprecated = { required-update = "minor" } | ||
| type_method_marked_deprecated = { required-update = "minor" } | ||
|
|
Member
There was a problem hiding this comment.
In Astra's words
Adds an unnecessary trailing blank line to the root Cargo.toml.
lol
Frando
enabled auto-merge
September 25, 2026 07:40
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2026
Arqu
approved these changes
Sep 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2026
Frando
enabled auto-merge
September 28, 2026 08:01
gsnaiper
pushed a commit
to gsnaiper/iroh
that referenced
this pull request
Oct 8, 2026
## Description Adds counters to track lookup success rates and also tracks it by type of resolver. Also updates iroh-metrics to 1.0.2. ## API Changes <!-- Optional, any API additions, deprecations or breaking changes, including how to migrate older code. --> ## Notes & open questions * Previously merged as n0-computer#4411 and reverted in n0-computer#4542 because it broke semver: Adding a `Family` made `EndpointMetrics` no longer implement `UnwindSafe`. n0-computer/iroh-metrics#137 fixes this by making `Family` be `UnwindSafe`. * Min crates check is expected to fail, because iroh-metrics 1.0.2 is newer than 3 days. It's our own crate, so this is fine. ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] Tests if relevant. - [x] All API changes documented. - [x] This PR was created by a human that thought critically about the proposed change and wrote an as clear and concise description as they could. - [x] This PR isn't slop, and is carefully crafted to do have the intented effect. --------- Co-authored-by: Asmir Avdicevic <asmir.avdicevic64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds counters to track lookup success rates and also tracks it by type of resolver.
Also updates iroh-metrics to 1.0.2.
API Changes
Notes & open questions
FamilymadeEndpointMetricsno longer implementUnwindSafe. fix: makeFamilybeUnwindSafeiroh-metrics#137 fixes this by makingFamilybeUnwindSafe.Change checklist
proposed change and wrote an as clear and concise description as
they could.
intented effect.