Skip to content

fix(ci): fix arm builds and some cleanup #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arqu merged 1 commit into from
Apr 20, 2026
Merged

fix(ci): fix arm builds and some cleanup #4139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,32 +178,17 @@ jobs:
if: matrix.os != 'windows-latest'
shell: bash
run: |
if [ "${{ matrix.name }}" = "ubuntu-arm-latest" ]; then
export CARGO_TARGET_AARCH64_UNKNOWN_LINUX_MUSL_LINKER=aarch64-linux-gnu-gcc
export CC=aarch64-linux-gnu-gcc
if [ "${{ contains(matrix.cargo_targets, '-musl') }}" = "true" ]; then
# Native build on self-hosted linux runners; use musl-gcc from musl-tools.
export CARGO_TARGET_$(echo ${{ matrix.cargo_targets }} | tr 'a-z-' 'A-Z_')_LINKER=musl-gcc
export CC=musl-gcc
fi
cargo build --profile optimized-release --all-features --target ${{ matrix.cargo_targets }}

- name: build release
if: matrix.os == 'windows-latest'
run: cargo build --profile optimized-release --all-features --target ${{ matrix.cargo_targets }}

- name: attach artifacts

@dignifiedquire dignifiedquire Apr 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these gone?

@Arqu Arqu Apr 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have an iroh binary a long time already :)

@dignifiedquire dignifiedquire Apr 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

riight 🤣

if: matrix.os != 'windows-latest'
uses: actions/upload-artifact@v7
with:
name: iroh-${{env.RELEASE_OS }}-${{env.RELEASE_ARCH}}
path: target/${{ matrix.cargo_targets }}/optimized-release/iroh
compression-level: 0

- name: attach artifacts
if: matrix.os == 'windows-latest'
uses: actions/upload-artifact@v7
with:
name: iroh-windows-amd64.exe
path: target/${{ matrix.cargo_targets }}/optimized-release/iroh.exe
compression-level: 0

- name: Cache AWS CLI
if: matrix.os != 'windows-latest'
id: cache-awscli
Expand Down
Loading