Open
Conversation
Also changed the built in visitor methods signature to `protected` to enable customizing sub-visitor flows by overriding. fixes mysticatea#12
|
@mysticatea can you please merge this (or reject it) so we can have access to RegExpVisitor? I really don't want to publish an alternate version of regexpp but we need access to use this in other parser libraries. Thank you for your attention. |
|
Hi @bd82! Since this repo is unmaintained, you might want to re-open this PR in the @eslint-community fork https://github.com/eslint-community/regexpp For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also changed the built in visitor methods signature to
protectedto enable customizing sub-visitor flows by overriding.
fixes #12