-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get register of interest via API #194
Conversation
twfy host now has poetry - so this should work even in advance of the twfy poetry pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue with missing jinja2. To be honest, I didn't follow all the code (perhaps some doctests of e.g. move_subitems_under_parent to show an example would be nice, not sure I understood the "parents" stuff), but if you're happy with the output, fine with me :)
Added above - added some more commentary on the subitem movements because that wasn't clear. Added one extra fix that was needed for a march register to manually fetch a not present parent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Parliament's turned off their old site, so our scraper is broken!
This scopes out the old parser, adds a new parser that converts the Parliament API into the XML TheyWorkForYou expects.
As seen in
dailyupdate
, this can be run via:This updates some requirements in the poetry, and also uses this poetry config for the first time in production.
Rather than exactly replicating the previous structure, there's now a bit more use of lists to reflect how parliament sees items and subitems.
I've tested this in both the import to database:
And the comparison over time:
There's a boundary problem in that the sudden change will break the retrospect. If we delete and recreate the last few items though, this should be less of a problem.
Also have the option if reviewing this will take a while to just upload the generated files manually (given they seem fine).