Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff Formatter to parlparse #184

Merged
merged 8 commits into from
Oct 7, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Include silent fix as part of linting
  • Loading branch information
ajparsons committed Sep 26, 2024
commit a4543e88be34765ce3ec34c30560d2d1caa57f13
8 changes: 7 additions & 1 deletion script/lint
Original file line number Diff line number Diff line change
@@ -2,9 +2,15 @@

poetry run ruff format .

# We run the fix check so it can auto fix issues we're ignoring below
# but we don't want to fail the check if it can't fix them
# because there are known issues
# we fail on a smaller subset below
poetry run ruff check . -s --fix || true

# This ignores a number of linting checks that are *problems* and so
# we want to be able to see in editor (and can't put in pyproject.toml)
# but we don't want to have to fix everything (given it's working fineish)
# to see new issues
# this is the 'using is' for equality, top module imports broken by chdir, don't use lambdas, etc
poetry run ruff check . --fix --config 'lint.ignore = ["E501", "E402", "E731", "E722", "F841", "E711", "E712"]'
poetry run ruff check . --config 'lint.ignore = ["E501", "E402", "E731", "E722", "F841", "E711", "E712"]'
Loading