Mailing list backend utilities #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidation strings to use variables
| @@ -1,4 +1,33 @@ | |||
| var endpoints = { | |||
|
|
|||
| mailinglist: { | |||
There was a problem hiding this comment.
As discussed, please pluralize so these become /mailinglists and so on.
| } | ||
| }; | ||
| var requiredId = _.assign(_.clone(id), {presence: {message: "^empty"}}); |
There was a problem hiding this comment.
Is it necessary to clone if it's only read from?
|
CR done. |
|
Will do one PR for all the changes instead of 3, will be easier to see everything at once |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of backend method for the mailing lists.
Right now no UI what so ever.
I wanted to make a PR to show where I am right now and to fix concerns asap.
Routes were tested with Postman