Repository navigation
syntax: preserve indentation in nested tab heredocs - #1408
Closed
err0r4eve3 wants to merge 1 commit into
Closed
err0r4eve3 wants to merge 1 commit into
err0r4eve3 wants to merge 1 commit into
Conversation
Contributor
|
? |
Owner
|
Let's pretend you did not just copy paste someone else's patch and put your name on it. |
Author
|
You are right. This PR reproduced the patch @milhnl had already posted in #1403, including the regression test, and I failed to credit that source before submitting it. I apologize to @milhnl and the maintainers. The attribution failure is entirely mine. The PR is closed, and I will not submit further work to this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extraIndenter.WriteByte, matching its existing string path<<-heredocsThe bug is specific to nesting because an inner
extraIndenterflushes each completed line withe.bufWriter.Write. When that underlying writer is an outerextraIndenter, its embeddedWritemethod was promoted and bypassed the outer writer's per-line indentation state. ImplementingWriteonextraIndenterkeeps every writer entry point on the same path.Test
go test ./...Fixes #1403