fix: Content shifts when <media-volume-range> control is tab-focused#1255
fix: Content shifts when <media-volume-range> control is tab-focused#1255ignasio-mux wants to merge 1 commit intomuxinc:mainfrom
Conversation
|
@ignasio-mux is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
==========================================
- Coverage 78.55% 73.62% -4.94%
==========================================
Files 59 56 -3
Lines 11080 13709 +2629
Branches 0 783 +783
==========================================
+ Hits 8704 10093 +1389
- Misses 2376 3583 +1207
- Partials 0 33 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| cursor: var(--media-cursor, pointer); | ||
| pointer-events: auto; | ||
| touch-action: none; ${/* Prevent scrolling when dragging on mobile. */ ''} | ||
| overflow: hidden; ${/* Prevent absolute positioned #range from affecting parent layout on focus */ ''} |
There was a problem hiding this comment.
This can't be used here because preview time, thumbnail etc would be clipped.
You have to be very careful with using overflow: hidden in players with things like tooltips, popovers, menus.
Try to make the dimensions of the extruding element fit the bounds of the container instead.
There was a problem hiding this comment.
This is the line that causes the issue:
media-chrome/src/js/media-chrome-range.ts
Line 98 in 4b1f5a9
Can we remove that -5px?
This PR closes #1254
Added overflow: hidden to the :host element to prevent the absolutely positioned #range input from affecting the parent container's layout when it receives focus