Skip to content

fix: Content shifts when <media-volume-range> control is tab-focused#1255

Open
ignasio-mux wants to merge 1 commit intomuxinc:mainfrom
ignasio-mux:fix/unexpected_padding
Open

fix: Content shifts when <media-volume-range> control is tab-focused#1255
ignasio-mux wants to merge 1 commit intomuxinc:mainfrom
ignasio-mux:fix/unexpected_padding

Conversation

@ignasio-mux
Copy link
Contributor

This PR closes #1254

Added overflow: hidden to the :host element to prevent the absolutely positioned #range input from affecting the parent container's layout when it receives focus

@ignasio-mux ignasio-mux requested review from a team and heff as code owners December 19, 2025 16:55
@vercel
Copy link

vercel bot commented Dec 19, 2025

@ignasio-mux is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io
Copy link

snyk-io bot commented Dec 19, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.62%. Comparing base (3ea80df) to head (d955b8c).
⚠️ Report is 275 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
- Coverage   78.55%   73.62%   -4.94%     
==========================================
  Files          59       56       -3     
  Lines       11080    13709    +2629     
  Branches        0      783     +783     
==========================================
+ Hits         8704    10093    +1389     
- Misses       2376     3583    +1207     
- Partials        0       33      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
media-chrome Ready Ready Preview, Comment Dec 19, 2025 5:51pm

cursor: var(--media-cursor, pointer);
pointer-events: auto;
touch-action: none; ${/* Prevent scrolling when dragging on mobile. */ ''}
overflow: hidden; ${/* Prevent absolute positioned #range from affecting parent layout on focus */ ''}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be used here because preview time, thumbnail etc would be clipped.

You have to be very careful with using overflow: hidden in players with things like tooltips, popovers, menus.

Try to make the dimensions of the extruding element fit the bounds of the container instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the line that causes the issue:

bottom: var(--media-time-range-hover-bottom, -5px);

Can we remove that -5px?

@ignasio-mux ignasio-mux requested a review from luwes January 15, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content shifts when <media-volume-range> control is tab-focused

2 participants