Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import and Export buttons to the Parametric Equalizer DSP #800

Merged

Conversation

maximmaxim345
Copy link
Contributor

@maximmaxim345 maximmaxim345 commented Jan 2, 2025

Overview

This PR adds support for importing and exporting Parametric Equalizer presets.

Equalizer APO's file format is widely adopted in various applications, and this import functionality also works seamlessly with REW's Export filter settings as text file format.
While not all filter types are supported (Modal, BP, LSC x dB, HS x dB, AP, LS with dB slope, HS with dB slope), the most important ones are functional.

Currently, the Preamp option is not supported. This may change in the future.

Testing

I tested this with:

  • An Equalizer preset exported from REW
  • An Equalizer preset exported from EasyEffects (as APO preset)
  • An example REW-compatible preset from https://housecurve.com/
  • Importing a Music Assistant exported preset into EasyEffects

Screenshot

image

This commit adds both import and export of the ParametricEQ DSP Filter
as Equalizer APO compatible files.

Since Equalizer Presets in APO's file format are widely adapted, this
also allows importing the user to import the EQ generated by REW or
similar software.

For now some advanced PEQ filter types are not supported.

Preamp is also not supported and set to 0dB.
@maximmaxim345 maximmaxim345 changed the title Add import and Export buttons to the Parametric Equalizers DSP Add import and Export buttons to the Parametric Equalizer DSP Jan 2, 2025
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work again!

@marcelveldt marcelveldt merged commit 9c2ec0b into music-assistant:main Jan 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants