fix: correct arity for generic codec signatures #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mununki#105 Generic types with multiple type parameters generated codec functions with incorrect arity, causing each codec parameter to be curried separately instead of grouped as an uncurried tuple. - Refactored `add_encoder_params` and `add_decoder_params` to use `List.fold_right` and set the outer function arity to the total number of type parameters - Refactored `add_params` to count parameters and set correct arity Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Records: t5<'data>, t6<'key, 'value> - Variants: t5<'a>, t6<'a, 'b> - Polyvariants: t3<'a>, t4<'a, 'b> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
Generic types with multiple type parameters generated codec functions
with incorrect arity, causing each codec parameter to be curried
separately instead of grouped as an uncurried tuple.
add_encoder_paramsandadd_decoder_paramsto useList.fold_rightand set the outer function arity to the totalnumber of type parameters
add_paramsto count parameters and set correct arity