Skip to content

Comments

🔧 Run ty check through uvx prek run -a ty-check#323

Merged
burgholzer merged 1 commit intomainfrom
run-ty-through-prek
Feb 18, 2026
Merged

🔧 Run ty check through uvx prek run -a ty-check#323
burgholzer merged 1 commit intomainfrom
run-ty-through-prek

Conversation

@burgholzer
Copy link
Member

Description

Instead of curating the command in CI, let each repo's local prek config handle how to run ty

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

Instead of curating the command in CI, let each repo's local prek config handle how to run `ty`
@burgholzer burgholzer self-assigned this Feb 18, 2026
@burgholzer burgholzer added continuous integration Anything related to the CI setup python Anything related to Python code labels Feb 18, 2026
@burgholzer burgholzer merged commit 4e98c97 into main Feb 18, 2026
5 checks passed
@burgholzer burgholzer deleted the run-ty-through-prek branch February 18, 2026 10:08
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Streamlined the type-checking process in the development workflow, consolidating the execution into a single unified command for improved efficiency.

Walkthrough

The pull request consolidates the Ty type-check invocation in the reusable Python linter GitHub workflow from a two-step sequence into a single command, and documents this change in the changelog.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/reusable-python-linter.yml
Consolidates Ty type-check invocation from two-step sequence (uv sync --no-install-project; uv run --no-sync ty check) to single command (uvx prek run -a ty-check).
Changelog Documentation
CHANGELOG.md
Adds Unreleased "Changed" section entry documenting the Ty check invocation update and corresponding PR reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • workflows#254: Directly modifies the same Ty/type-check step in the reusable Python linter workflow with related consolidation of the invocation.
  • workflows#255: Modifies the same "Run ty" step in the reusable Python linter workflow to update how the ty linter is invoked.
  • workflows#257: Modifies the same "Run ty" step in the reusable Python linter workflow to simplify the ty check invocation.

Suggested reviewers

  • denialhaag

Poem

🐰 One command now where two did dance,
Through uvx prek we quicken pace,
The linter runs with flair and grace,
Simpler steps, a cleaner stance! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch run-ty-through-prek

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous integration Anything related to the CI setup python Anything related to Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant