Fix client side debugscript level filtering (#3498) #4323
+27
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Add CheckForSufficientDebugLevel method for proper level checking • Implement console output filtering based on player debug level • Add debug level enums with legacy numeric level support • Align client-side behavior with server-side debug filtering
MegadreamsBE
suggested changes
Jul 31, 2025
…bCodeX/mtasa-blue into debugscript-client-behavior
MegadreamsBE
approved these changes
Aug 1, 2025
tederis
requested changes
Aug 5, 2025
| @@ -33,13 +33,13 @@ CScriptDebugging::~CScriptDebugging() | |||
| fprintf(m_pLogFile, "INFO: Logging to this file ended\n"); | |||
|
|
|||
| // if we have a flush timer | |||
| if (m_flushTimerHandle != NULL) | |||
| if (m_flushTimerHandle != nullptr) | |||
There was a problem hiding this comment.
Can be reduced: if (m_flushTimerHandle)
| @@ -52,7 +52,7 @@ void CScriptDebugging::LogBadLevel(lua_State* luaVM, unsigned int uiRequiredLeve | |||
| void CALLBACK TimerProc(void* lpParametar, BOOLEAN TimerOrWaitFired) | |||
| { | |||
| // Got a logfile? | |||
| if (CScriptDebugging::m_pLogFile != NULL) | |||
| if (CScriptDebugging::m_pLogFile != nullptr) | |||
There was a problem hiding this comment.
Can be reduced: if (CScriptDebugging::m_pLogFile)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3498
you can test using this script which has a lot of test options
dbgtest.zip