Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setVehicleVariant turns on the engine #3486

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix setVehicleVariant turns on the engine #3486

wants to merge 6 commits into from

Conversation

Proxy-99
Copy link
Contributor

Fixes #542

@tederis tederis added the bugfix Solution to a bug of any kind label Jun 17, 2024
@Proxy-99 Proxy-99 requested review from tederis and TracerDS June 18, 2024 19:04
TracerDS
TracerDS approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@TracerDS TracerDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Client/mods/deathmatch/logic/CClientVehicle.cpp Outdated Show resolved Hide resolved
Nico8340
Nico8340 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@botder botder added the backwards-incompatible Should be merged after the release of 1.6.1 label Jun 26, 2024
@Fernando-A-Rocha
Copy link
Contributor

merge this for 1.6.1 with backwards incompatible label?
https://wiki.multitheftauto.com/wiki/Changes_in_1.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fernando-A-Rocha Fernando-A-Rocha Fernando-A-Rocha approved these changes

@TracerDS TracerDS TracerDS approved these changes

@Nico8340 Nico8340 Nico8340 approved these changes

@tederis tederis Awaiting requested review from tederis

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backwards-incompatible Should be merged after the release of 1.6.1 bugfix Solution to a bug of any kind
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setVehicleVariant turns on the engine, getVehicleEngineState still returns false
6 participants
@Proxy-99 @Fernando-A-Rocha @tederis @TracerDS @Nico8340 @botder