Render cube map textures on box geoms#23
Merged
Merged
Conversation
Box geoms with a cube map material were drawn as a flat-colored box. Build a 6-quad textured mesh from a vertical-strip atlas so per-face textures display, and group such boxes by texture so they merge correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Box geoms with a cube map material were drawn as a flat-colored box, so per-face cube textures did not show up in the viewer. This builds a 6-quad textured mesh from a vertical-strip atlas for such boxes so each face's image displays, and groups cube-textured boxes by texture so they merge correctly.
The cube-map validation and face-axis array that were duplicated across the existing mesh path and the new box path are now shared helpers. Added tests covering mesh structure, extents, per-face order and placement, the flat-color fallback for plain and 2D-textured boxes, and texture grouping.