-
-
Notifications
You must be signed in to change notification settings - Fork 285
[internal] Fix useHover interaction hook duplication
#3481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
704614a to
2a82652
Compare
2a82652 to
69a603f
Compare
|
This conflicts a lot with #3451, it would have been nice to wait for that to be completed before doing a refactor here. |
|
Ultimately all components should use the new hooks, so there's no need for |
Removes duplication from detached triggers refactoring.
useHoverReferenceInteraction/useHoverFloatingInteractionuseHovernow callsuseHoverReferenceInteraction/useHoverFloatingInteractionand doesn't duplicate all the code