Skip to content

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Dec 9, 2025

Removes duplication from detached triggers refactoring.

  • Fixes duplication of callbacks between useHoverReferenceInteraction/useHoverFloatingInteraction
  • useHover now calls useHoverReferenceInteraction/useHoverFloatingInteraction and doesn't duplicate all the code

@atomiks atomiks added the internal Behind-the-scenes enhancement. Formerly called “core”. label Dec 9, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 9, 2025

  • vite-css-base-ui-example

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/react@3481
    
    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/utils@3481
    

commit: 69a603f

@mui-bot
Copy link

mui-bot commented Dec 9, 2025

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react ▼-4.06KB(-0.99%) ▼-1.18KB(-0.90%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Dec 9, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 69a603f
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69389820faefb50008cc3c91
😎 Deploy Preview https://deploy-preview-3481--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks force-pushed the refactor/useHover-duplication branch 2 times, most recently from 704614a to 2a82652 Compare December 9, 2025 21:37
@romgrk
Copy link
Contributor

romgrk commented Dec 9, 2025

This conflicts a lot with #3451, it would have been nice to wait for that to be completed before doing a refactor here.

@atomiks
Copy link
Contributor Author

atomiks commented Dec 9, 2025

@romgrk yeah, sorry. While working on #3482, I noticed all the duplication as the updates needed to be made across 3 different files and refactored it.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 10, 2025
@michaldudak
Copy link
Member

Ultimately all components should use the new hooks, so there's no need for useHover anymore. AFAIK, just NavigationMenu and PreviewCard still call useHover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. PR: out-of-date The pull request has merge conflicts and can't be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants