[Collapsible][Accordion] Recalculate panel dimensions on layout resize #1704
+84
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
component: collapsible
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
atomiks
changed the title
atomiks
force-pushed
the
collapsible-accordion-resize
branch
from
4098859 to
33f5610
Compare
mj12albert
reviewed
Apr 15, 2025
| } | ||
|
|
||
| const win = ownerWindow(panel); | ||
| win.addEventListener('resize', handleWindowResize); |
There was a problem hiding this comment.
Testing this a bit and it works well, just wondering is it not enough to only use ResizeObserver?
There was a problem hiding this comment.
In this case the ResizeObserver fires when transitioning the height, which is why I added if (panel.getAnimations().length > 0) { to prevent its logic from running, but when resizing the window, I don't want any animations to occur so the resizing is 1:1 with layout.
For this purpose we can't reuse the ResizeObserver since we want regular transitions to work when opening/closing
mj12albert
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1458