Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Use local useInteractions #1247

Closed
wants to merge 1 commit into from
Closed

[core] Use local useInteractions #1247

wants to merge 1 commit into from

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Dec 30, 2024

Part of #1246. This prevents another mergeProps utility from being included in the bundle as we reuse the one locally.

@atomiks atomiks added the core Infrastructure work going on behind the scenes label Dec 30, 2024
@mui-bot
Copy link

mui-bot commented Dec 30, 2024

Netlify deploy preview

https://deploy-preview-1247--base-ui.netlify.app/

Generated by 🚫 dangerJS against e133094

@atomiks
Copy link
Contributor Author

atomiks commented Dec 30, 2024

This hook has special properties inside Floating UI and can't be replicated locally

@atomiks atomiks closed this Dec 30, 2024
@atomiks atomiks deleted the core/local-use-interactions branch December 30, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atomiks @mui-bot