-
Notifications
You must be signed in to change notification settings - Fork 10
Fix overflow when using large raster sizes #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… support larger inputs Signed-off-by: netthier <[email protected]>
Signed-off-by: netthier <[email protected]>
Signed-off-by: netthier <[email protected]>
Signed-off-by: netthier <[email protected]>
Signed-off-by: netthier <[email protected]> Co-authored-by: Matthieu Viry <[email protected]>
Signed-off-by: netthier <[email protected]>
Huh, what's that failure on nightly there? Seems like f32 literals are broken? UPDATE: I think we're hitting rust-lang/rust#123824, it should be fine to ignore? Though maybe explicitly specifying a type would make sense here, this doesn't seem well-defined. Let me know if you want me to add that to this PR or not. |
Do not merge this, it seems like there is another precision issue. I'll post more details in the issue |
Yeah I think so. The PR fixing the issue you reference seems to be in the merge queue so no need to worry about that, I think.
Alright :-/ |
Signed-off-by: netthier <[email protected]> Co-Authored-by: Matthieu Viry <[email protected]>
Great, thanks for your contribution. I will merge this now (and make a new release later today) because it brings improvements and corrections that are already useful. |
This fixes #12.
It contains breaking changes, as some
u32
s in public function signatures have been swapped withusize
s, requiring an appropriate version bump.