Skip to content

Fix overflow when using large raster sizes #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

netthier
Copy link
Contributor

This fixes #12.
It contains breaking changes, as some u32s in public function signatures have been swapped with usizes, requiring an appropriate version bump.

netthier and others added 6 commits April 11, 2024 18:05
Signed-off-by: netthier <[email protected]>
Co-authored-by: Matthieu Viry <[email protected]>
Signed-off-by: netthier <[email protected]>
@netthier
Copy link
Contributor Author

netthier commented Apr 12, 2024

Huh, what's that failure on nightly there? Seems like f32 literals are broken?

UPDATE: I think we're hitting rust-lang/rust#123824, it should be fine to ignore? Though maybe explicitly specifying a type would make sense here, this doesn't seem well-defined. Let me know if you want me to add that to this PR or not.

@netthier netthier marked this pull request as draft April 12, 2024 13:20
@netthier
Copy link
Contributor Author

Do not merge this, it seems like there is another precision issue. I'll post more details in the issue

@mthh
Copy link
Owner

mthh commented Apr 12, 2024

I think we're hitting rust-lang/rust#123824 [...] Let me know if you want me to add that to this PR or not.

Yeah I think so. The PR fixing the issue you reference seems to be in the merge queue so no need to worry about that, I think.

it seems like there is another precision issue. I'll post more details in the issue

Alright :-/

Signed-off-by: netthier <[email protected]>
Co-Authored-by: Matthieu Viry <[email protected]>
@netthier netthier marked this pull request as ready for review April 15, 2024 10:45
@mthh
Copy link
Owner

mthh commented Apr 15, 2024

Great, thanks for your contribution. I will merge this now (and make a new release later today) because it brings improvements and corrections that are already useful.
And we'll continue the discussion on #14.

@mthh mthh merged commit 2e58cfb into mthh:master Apr 15, 2024
4 checks passed
@netthier netthier deleted the fix-overflow branch April 15, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow/Artifacts with large rasters (>40k*40k)
2 participants