feat/offline-dashboard-loading#3
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the dashboard to be offline-safe by removing remote CDN dependencies and rendering with inline SVG. It also updates the documentation and test suite to reflect these changes. I have identified two bugs in the parseYear function in dashboard/dashboard.js: one where the year 0 is incorrectly treated as falsy, and another where slice(0, 4) truncates years with more than four digits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offline-safe unified dashboard loading.\n\nSummary:\n- Dashboard now loads only local manifest/CSV assets\n- Removed dependency on remote runtime/CDN loading\n- Rendered unified dashboard with inline SVG\n- Fixed dashboard sizing so content appears in browser screenshots\n- Updated tests and repo handoff docs\n- Regenerated affected plot outputs and site artifacts\n\nVerification:\n- pytest tests/test_dashboard.py tests/test_browser_smoke.py -q → 10 passed\n- python scripts/browser_smoke.py → PASS for homepage, dashboard, and AI Compute Timeline\n- Headless browser screenshots verified the dashboard on desktop and mobile\n\nCommit: 509d20d (feat: offline-safe dashboard loading)\nBranch: feat/offline-dashboard-loading