Use LINQ instead of foreach()

msarilar · Dec 24, 2022 · 781e656 · 781e656
1 parent 02a3c7f
commit 781e656
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/EDEngineer/Views/ShoppingListViewModel.cs b/EDEngineer/Views/ShoppingListViewModel.cs
@@ -248,17 +248,12 @@ public IEnumerator<Blueprint> GetEnumerator()
                 yield break;
             }
 
-            var composition = new List<BlueprintIngredient>();
-            foreach (var i in ingredients)
-            {
-                composition.Add(new BlueprintIngredient(i.Key, i.Value));
-            }
-
-            composition = composition.OrderBy(i => i.Entry.Count - i.Size > 0 ? 1 : 0)
-                                     .ThenByDescending(i => i.Entry.Data.Subkind)
-                                     .ThenBy(i => i.Entry.Data.Kind)
-                                     .ThenBy(i => languages.Translate(i.Entry.Data.Name))
-                                     .ToList();
+            var composition = ingredients.Select(i => new BlueprintIngredient(i.Key, i.Value))
+                                         .OrderBy(i => i.Entry.Count - i.Size > 0 ? 1 : 0)
+                                         .ThenByDescending(i => i.Entry.Data.Subkind)
+                                         .ThenBy(i => i.Entry.Data.Kind)
+                                         .ThenBy(i => languages.Translate(i.Entry.Data.Name))
+                                         .ToList();
 
             var metaBlueprint = new Blueprint(languages,
                 "",