fix: enable macOS and tvOS in podspec #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
YOLO LGTM - thanks for your PR!!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yolo'd this to unblock my react-native-macos app, which I am migrating to the new architecture.
With the new architecture enabled, I tested this change for macOS by running it with react-native-test-app.
I restored the podspec to the previous code that was here in the history using git blame. I did not test tvOS support against this change, but I saw that #713 was open and asked for this change as well.
What else would you like to see in this PR? Examples, tests, etc.?
Also, it is unclear to me what the min versions should be in the podspec for tvOS and macOS.