Skip to content

GLTFLoader: Ensure material extensionsUsed are also in top-level extensionsUsed #32671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mlt131220 wants to merge 4 commits into from
+6 −0
Closed

GLTFLoader: Ensure material extensionsUsed are also in top-level extensionsUsed #32671

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4682da
GLTFLoader: Ensure `material extensionsUsed` are also in top-level `e…
mlt131220 Jan 5, 2026
4d5184e
Revert "GLTFLoader: Ensure `material extensionsUsed` are also in top-…
mlt131220 Jan 8, 2026
7e180d4
GLTFLoader: add register KHR_materials_unlit
mlt131220 Jan 8, 2026
36837c0
GLTFLoader: Remove the redundant `parser` parameters
mlt131220 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 43 additions & 22 deletions examples/jsm/loaders/GLTFLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,40 +500,61 @@ class GLTFLoader extends Loader {

}

if ( json.extensionsUsed ) {
// Ensure material extensionsUsed are also in top-level extensionsUsed
json.extensionsUsed = json.extensionsUsed || [];

for ( let i = 0; i < json.extensionsUsed.length; ++ i ) {
if ( json.materials ) {

const extensionName = json.extensionsUsed[ i ];
const extensionsRequired = json.extensionsRequired || [];
let materialExtensions = {};

switch ( extensionName ) {
for ( let i = 0; i < json.materials.length; i++ ) {

case EXTENSIONS.KHR_MATERIALS_UNLIT:
extensions[ extensionName ] = new GLTFMaterialsUnlitExtension();
break;
const material = json.materials[ i ];

case EXTENSIONS.KHR_DRACO_MESH_COMPRESSION:
extensions[ extensionName ] = new GLTFDracoMeshCompressionExtension( json, this.dracoLoader );
break;
materialExtensions = { ...materialExtensions, ...( material.extensions || {} ) };

case EXTENSIONS.KHR_TEXTURE_TRANSFORM:
extensions[ extensionName ] = new GLTFTextureTransformExtension();
break;
}

case EXTENSIONS.KHR_MESH_QUANTIZATION:
extensions[ extensionName ] = new GLTFMeshQuantizationExtension();
break;
const materialExtensionNames = Object.keys( materialExtensions );

default:
if ( materialExtensionNames.length > 0 ) {

if ( extensionsRequired.indexOf( extensionName ) >= 0 && plugins[ extensionName ] === undefined ) {
json.extensionsUsed = [ ...new Set( [ ...json.extensionsUsed, ...materialExtensionNames ] ) ];

console.warn( 'THREE.GLTFLoader: Unknown extension "' + extensionName + '".' );
}

}
}

}
for ( let i = 0; i < json.extensionsUsed.length; ++ i ) {

const extensionName = json.extensionsUsed[ i ];
const extensionsRequired = json.extensionsRequired || [];

switch ( extensionName ) {

case EXTENSIONS.KHR_MATERIALS_UNLIT:
extensions[ extensionName ] = new GLTFMaterialsUnlitExtension();
break;

case EXTENSIONS.KHR_DRACO_MESH_COMPRESSION:
extensions[ extensionName ] = new GLTFDracoMeshCompressionExtension( json, this.dracoLoader );
break;

case EXTENSIONS.KHR_TEXTURE_TRANSFORM:
extensions[ extensionName ] = new GLTFTextureTransformExtension();
break;

case EXTENSIONS.KHR_MESH_QUANTIZATION:
extensions[ extensionName ] = new GLTFMeshQuantizationExtension();
break;

default:

if ( extensionsRequired.indexOf( extensionName ) >= 0 && plugins[ extensionName ] === undefined ) {

console.warn( 'THREE.GLTFLoader: Unknown extension "' + extensionName + '".' );

}

}

Expand Down