Skip to content

GLTFExporter: Push nodes parent-first instead of child-first #31125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

GLTFExporter: Push nodes parent-first instead of child-first #31125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions examples/jsm/exporters/GLTFExporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2408,6 +2408,9 @@ class GLTFWriter {

if ( object.isSkinnedMesh ) this.skins.push( object );

const nodeIndex = json.nodes.push( nodeDef ) - 1;
nodeMap.set( object, nodeIndex );

if ( object.children.length > 0 ) {

const children = [];
Expand All @@ -2418,9 +2421,9 @@ class GLTFWriter {

if ( child.visible || options.onlyVisible === false ) {

const nodeIndex = await this.processNodeAsync( child );
const childNodeIndex = await this.processNodeAsync( child );

if ( nodeIndex !== null ) children.push( nodeIndex );
if ( childNodeIndex !== null ) children.push( childNodeIndex );

}

Expand All @@ -2436,8 +2439,6 @@ class GLTFWriter {

} );

const nodeIndex = json.nodes.push( nodeDef ) - 1;
nodeMap.set( object, nodeIndex );
return nodeIndex;

}
Expand Down