Port to GNOME 45 #31
Open
Port to GNOME 45 #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to changes to the JS module system, a shell extension can only be compatible with GNOME <= 44 OR with GNOME >= 45, so we have to remove compatibility with older versions. As a sidenote, extensionUtils.initTranslations() does not have to be called explicitly anymore. It will be called by the framework instead. See also: https://gjs.guide/extensions/upgrading/gnome-shell-45.html
Extension.lookupByURL returns null while loading the JS files of an extension, and only returns a non-null value after the constructor of the ExtensionModule has returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNOME Shell 45 moved to ESM (ECMAScript modules), which means that it is not backwards compatible with extensions that target GNOME <= 44 (https://gjs.guide/extensions/upgrading/gnome-shell-45.html).
This PR makes all the necessary changes to make this extension work on GNOME 45 (and hopefully later versions as well).