Skip to content

Conversation

@layercak3
Copy link
Contributor

Fixes panning the video while it's paused and the OSD isn't redrawing. wayland_common since c251293 requests redraw when there is a resize event so there was no issue with xdg resizing but that isn't applicable to resizing due to panscan options changing.

Fixes panning the video while it's paused and the OSD isn't redrawing.
wayland_common since c251293 requests
redraw when there is a resize event so there was no issue with xdg
resizing but that isn't applicable to resizing due to panscan options
changing.
@kasper93 kasper93 requested a review from Dudemanguy October 24, 2025 09:06
Copy link
Member

@Dudemanguy Dudemanguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at other VOs it does look like keeping the vo->want_redraw state separate from resize is not actually necessary. MPV's core already handles if a vo->want_redraw request is not needed. So yeah LGTM.

@Dudemanguy Dudemanguy merged commit 4468534 into mpv-player:master Oct 26, 2025
27 of 29 checks passed
@layercak3 layercak3 deleted the dmabuf-pan-redraw branch October 27, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants