Merge Develop Changes into Main #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reworked CMake to remove duplicate and stray cmake code paths, as well as adding a CMake Module * Removed a few compile flag lines * Removed duplicate code setting language on files * Added packages to cmake configure file * Removed extra cmake line including directories already included
Initial style guide for formatting
* library target changed to locality aware * changed file names from mpix to mpil * blanket replacement of MPIX to MPIL, caps only * fixed targeting problem in unit tests * added in namespace scope to make install * changed mpi_advance.h to locality_aware.h in benchmark calls * change to CMakelist in Heter. to point to locality_aware * fixed link to enum name * added 'enum' to external enum declarations to avoid error when compling with c code
…ucture (#47) Major locality_aware.h, internal CMake, and source file location changes. Please see PR 47 for full description of changes. Key changes for end users: - New MPIL apis for setting which collective function should be used under the hood - Most internal functions are no longer callable by the end user; some have been upgraded into MPIL functions.
…o make tests and benchmarks share common function; added function to test all matrices
Bring in fix for zero sizes sends; abstract some common test functionality into methods
Removed Test Data Folder. I already have it all backed up, thank you!
… and most internal functions (#49) * Documented locality_aware.h * Outlined new README * Updated make_test to default to mpirun and allow the variable to be tweaked from CMake command line * Commented out openmp code that was untested * General code organization and cleanup * Updated HIP build * Fixed mis-aligned gpu to hip function * Moved mircobenchmark out of main builds
Updated README with funding information
…ecise CMake tesing flags, and removed stale branch targets
TheMasterDirk
approved these changes
Nov 19, 2025
Contributor
TheMasterDirk
left a comment
TheMasterDirk
left a comment
There was a problem hiding this comment.
Approving all changes, plus minor last second tweaks to cmake module and GitHub Actions workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the significant updates into the main branch.