uniffi::use_remote_type uses 'crate::name' form to specify types. (#2325

)
mozilla · Nov 23, 2024 · aa200a6 · aa200a6
1 parent e0fd13f
commit aa200a6
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/docs/manual/src/udl/remote_ext_types.md b/docs/manual/src/udl/remote_ext_types.md
@@ -92,7 +92,7 @@ Types that are remote and external require a `use_remote_type!` macro call.
 If `crate_a` defines [IpAddr](https://doc.rust-lang.org/std/net/enum.IpAddr.html) as a remote type, then `crate_b` can use that type with the following Rust code:
 
 ```rust
-uniffi::use_remote_type!(crate_a, IpAddr);
+uniffi::use_remote_type!(crate_a::IpAddr);
 ```
 
 ## UDL

diff --git a/fixtures/ext-types/lib/src/lib.rs b/fixtures/ext-types/lib/src/lib.rs
@@ -12,7 +12,7 @@ use uniffi_sublib::SubLibType;
 use url::Url;
 
 // Remote types require a macro call in the Rust source
-uniffi::use_remote_type!(custom_types, Url);
+uniffi::use_remote_type!(custom_types::Url);
 
 pub struct CombinedType {
     pub uoe: UniffiOneEnum,

diff --git a/fixtures/ext-types/proc-macro-lib/src/lib.rs b/fixtures/ext-types/proc-macro-lib/src/lib.rs
@@ -6,7 +6,7 @@ use uniffi_one::{
 };
 use url::Url;
 
-uniffi::use_remote_type!(custom_types, Url);
+uniffi::use_remote_type!(custom_types::Url);
 
 #[derive(uniffi::Record)]
 pub struct CombinedType {

diff --git a/uniffi_macros/src/remote.rs b/uniffi_macros/src/remote.rs
@@ -11,7 +11,7 @@ use syn::{
 
 pub struct RemoteTypeArgs {
     pub implementing_crate: Ident,
-    pub sep: Token![,],
+    pub sep: Token![::],
     pub ty: Type,
 }
-Original file line number
+Diff line change
@@ Expand Up @@
     If `crate_a` defines [IpAddr](https://doc.rust-lang.org/std/net/enum.IpAddr.html) as a remote type, then `crate_b` can use that type with the following Rust code:
     ```rust
-    uniffi::use_remote_type!(crate_a, IpAddr);
+    uniffi::use_remote_type!(crate_a::IpAddr);
     ```
     ## UDL
@@ Expand Down @@