-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove openssl dependency #2325
base: main
Are you sure you want to change the base?
Conversation
- Bump rouille from 3.5 => 3.6.2 rouille v3.6.2 fixed a bug: `rouille::Server::new_ssl` is now exposed when only `rustls` is enabled. - Disable default features of `reqwest` which pulls in openssl - Remove `openssl` pulled in `[dev-dependencies]` - Bump reqwest from 0.11.17 => 0.11.18 Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Use CRLF on windows and `\n` on Linux. Also fix formatting of `Cargo.toml` Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
In the commit, it would be nice to explicit why we want to remove it :) |
Done |
…ns do not contain sha1 support by default
0f3f94f
to
bca3500
Compare
The issue is somewhere in the delta:
The basic fields differ in |
@@ -128,11 +138,14 @@ cc = "1.0" | |||
chrono = "0.4.33" | |||
filetime = "0.2" | |||
itertools = "0.12" | |||
openssl = { version = "=0.10.64", features = ["vendored"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to embed the OpenSSL too? Why not just fully rely on rustls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for backward compatibility verification, it can be removed after a few releases. Feature gating [dev-dependencies]
unfortunately is not supported by cargo
.
Continuation of #1742
OpenSSL is a hinderance of both building and distribution, and has been superseeded by rustls and boringssl as safer and alternatives with sufficient subsets for sccache. We hance should not rely on a dependency when there are easier in alternatives.
Particularly difficult use cases when linking against OpenSSL: