[Bug]: promoted add-ons continue to be flagged for HR until an action in 2nd level approval queue is taken

[ioanarusiczki]

What happened?

Followup for #1982 (comment)

The scenario is:

1. an add-on is reported (abuse report for violating add-on policies) and flagged for HR in rev tools - the Manual Review Queue
2. version is rejected/disabled + the abuse report attached to the action
3. it's held for rejection and present in 2nd level approval queue
4. at this point if I check the Manual Review queue the version is still present here too and has NHR set
5. making a decision from 2nd level approval queue : proceed or approve

What did you expect to happen?

Only after a decision is taken in 2nd level approval queue the NHR and due date are removed from the Manual Review Queue

perhaps NHR should be cleared at step 2?

Is there an existing issue for this?

• I have searched the existing issues

┆Issue is synchronized with this Jira Task

[diox]

Need to investigate but I suspect it's not the same NHR. I think what's happening is:

• Reviewer rejects, that clears the NHR but the decision is held for 2nd level approval
• When auto-approve is attempted again, auto-approves notices the add-on is still awaiting review, and therefore set up a new NHR putting it back in the queue

[diox]

We should prevent new NHR from being added during auto-approval while an add-on is in the 2nd approval queue.