pulse_worker: don't prefetch more than one message (bug 1981900)#78
Merged
pulse_worker: don't prefetch more than one message (bug 1981900)#78
Conversation
If the first message fails and needs requeuing, the Consumer will immediately be given the next message in the batch. This leads to those message being processed out-of-order. By only fetching one message at a time, the Consumer will retrieve the failed message again on the next fetch. It will continue looping on this message forever until it succeeds, or someone intervenes. This is the desired behaviour. This ensures that no message goes silently unprocessed.
cgsheeh
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the first message fails and needs requeuing, the Consumer will immediately be given the next message in the batch. This leads to those message being processed out-of-order.
By only fetching one message at a time, the Consumer will retrieve the failed message again on the next fetch. It will continue looping on this message forever until it succeeds, or someone intervenes.
This is the desired behaviour. This ensures that no message goes silently unprocessed.
This also updates the test setup to be consistent on the queues that are created and used, as well as to use the correct
type(topic) as mandated by Pulse [0].[0] https://wiki.mozilla.org/Auto-tools/Projects/Pulse#:~:text=Exchanges%20MUST%20be%20topic%20exchanges
__str__showing push_id and repo_url