Skip to content

config: add .git to URLs for dev and stage, and test fixes (bug 1987822)#74

Merged
shtrom merged 2 commits intomainfrom
config-dev-stage
Sep 10, 2025
Merged

config: add .git to URLs for dev and stage, and test fixes (bug 1987822)#74
shtrom merged 2 commits intomainfrom
config-dev-stage

Conversation

@shtrom
Copy link
Member

@shtrom shtrom commented Sep 9, 2025

This is what's coming in the lando messages, and matches the state of the prod config.

This is what's coming in the lando messages, and matches the state of
the prod config.
@shtrom shtrom requested review from cgsheeh and zzzeid September 9, 2025 07:24
@shtrom shtrom marked this pull request as ready for review September 9, 2025 07:25
@zzzeid
Copy link
Contributor

zzzeid commented Sep 9, 2025

Tests seem to be failing?

@shtrom
Copy link
Member Author

shtrom commented Sep 10, 2025

Tests seem to be failing?

Yep. It only fails here, not locally. I doubt it's linked to this change, but that needs investigation.

Confirmed: same failure on a non-functional change to main #75

@shtrom
Copy link
Member Author

shtrom commented Sep 10, 2025

Remove the line-count assertion, as it was brittle and not testing
invariants we care about.
@shtrom shtrom changed the title config: add .git to URLs for dev and stage config: add .git to URLs for dev and stage, and test fixes (bug 1987822) Sep 10, 2025
@shtrom shtrom merged commit 965d1bd into main Sep 10, 2025
1 check passed
@shtrom shtrom deleted the config-dev-stage branch September 10, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants