-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22 feature improve demo UI #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, thanks @stefanfrench !
I pushed a tiny formatting commit to have aesthetic consistency on the code and made some comment-suggestions related to the markdown not being rendered properly.
Just a question, what does the queue=True
do in the event listeners in the demo/make_local_dataset_app.py
? I read the docs, but didnt really understand why its necessary in this app.
Co-authored-by: Kostis <[email protected]>
Co-authored-by: Kostis <[email protected]>
@Kostis-S-Z - thanks for reviewing. I removed the queue function as its not doing anything useful as far as i can tell. I added it originally as i was experimenting on trying to add a loading spinner for when the dataset loads, but it didn't work as expected. Let me know and I will merge this in |
Sounds good! Just run |
@Kostis-S-Z made some UI changes:
For the dataset app:
For the transcribe app: