Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22 feature improve demo UI #23

Merged
merged 9 commits into from
Feb 4, 2025

Conversation

stefanfrench
Copy link

@Kostis-S-Z made some UI changes:

For the dataset app:

  • Added a title and some instruction steps
  • Improved the layout of index and previous/ next
  • Changed it so that when you click save recording, you can then instantly record again instead of clicking on the 'x'
  • Added queue() which should help experience

For the transcribe app:

  • Added a title and some instruction steps

Copy link
Member

@Kostis-S-Z Kostis-S-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks @stefanfrench !
I pushed a tiny formatting commit to have aesthetic consistency on the code and made some comment-suggestions related to the markdown not being rendered properly.

Just a question, what does the queue=True do in the event listeners in the demo/make_local_dataset_app.py? I read the docs, but didnt really understand why its necessary in this app.

demo/make_local_dataset_app.py Outdated Show resolved Hide resolved
demo/make_local_dataset_app.py Show resolved Hide resolved
demo/transcribe_app.py Outdated Show resolved Hide resolved
@stefanfrench
Copy link
Author

@Kostis-S-Z - thanks for reviewing. I removed the queue function as its not doing anything useful as far as i can tell. I added it originally as i was experimenting on trying to add a loading spinner for when the dataset loads, but it didn't work as expected.

Let me know and I will merge this in

@Kostis-S-Z
Copy link
Member

Sounds good! Just run ruff format to fix the linting error and we merge it!

@Kostis-S-Z Kostis-S-Z merged commit 5f093aa into 16-finetune-own-data Feb 4, 2025
1 check passed
@Kostis-S-Z Kostis-S-Z deleted the 22-feature-improve-demo-ui branch February 4, 2025 22:41
@Kostis-S-Z Kostis-S-Z mentioned this pull request Feb 5, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants