fix(hid): add StreamDeck+ udev rule + correct HID migration default#1
Open
motoham88 wants to merge 1 commit into
Open
fix(hid): add StreamDeck+ udev rule + correct HID migration default#1motoham88 wants to merge 1 commit into
motoham88 wants to merge 1 commit into
Conversation
…-enables on upgrade (aethersdr#3257) Two root causes for StreamDeck+ going dark after the v26.6 opt-in gate (aethersdr#3258): 1. packaging/linux/60-hid-encoders.rules was missing the StreamDeck+ entry (0fd9:0084). Without it hidraw is root-only on Linux, so hid_open() fails silently and the device never initialises. 2. The v1 migration in MainWindow read HidEncoderAutoDetect with default "False", but the old code treated the key's *absence* as True (implicit default on line 8029). Users who never touched that setting had HID implicitly on, yet the migration wrote HidEncoderEnabled=False for them. V2 migration detects and corrects installs that were already written with the wrong default. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
60-hid-encoders.ruleshad no entry for the StreamDeck+ (0fd9:0084). On Linux, hidraw nodes are root-only without a udev rule, sohid_open()was failing silently — the device appeared in the Serial panel but never powered up.HidEncoderAutoDetectwith a fallback of"False", but the old code treated the key's absence as"True"(implicit default). Users who never explicitly set that key had HID working via the old always-on path, but the migration silently wroteHidEncoderEnabled=Falsefor them. A V2 one-shot migration now detects and corrects those installs.Test plan
HidEncoderEnabledflips toTrueon startup (check via Preferences → Serial checkbox state)Fixes regression introduced by aethersdr#3258.
🤖 Generated with Claude Code