Test refactoring

motinis · Jan 27, 2018 · a6144a7 · a6144a7
1 parent e5d998d
commit a6144a7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/test/java/gr/james/sampling/ChaoSamplingTest.java b/src/test/java/gr/james/sampling/ChaoSamplingTest.java
@@ -17,7 +17,7 @@ public class ChaoSamplingTest {
     private static final int REPS = 10000000;
 
     /**
-     * In {@link ChaoSampling} the appearance probability must be proportional to the item weight
+     * In {@link ChaoSampling} the appearance probability must be proportional to the item weight.
      */
     @Test
     public void correctness() {

diff --git a/src/test/java/gr/james/sampling/RandomSamplingTest.java b/src/test/java/gr/james/sampling/RandomSamplingTest.java
@@ -12,7 +12,7 @@
 import java.util.stream.IntStream;
 
 /**
- * Tests for unweighted algorithms (and weighted used as unweighted)
+ * Tests for unweighted algorithms (and weighted used as unweighted).
  */
 @RunWith(Parameterized.class)
 public class RandomSamplingTest {
@@ -41,7 +41,7 @@ public static Collection<Supplier<RandomSampling<Integer>>> implementations() {
     }
 
     /**
-     * All items must be selected with equal probability
+     * All items must be selected with equal probability.
      */
     @Test
     public void correctness() {

diff --git a/src/test/java/gr/james/sampling/WeightedRandomSamplingTest.java b/src/test/java/gr/james/sampling/WeightedRandomSamplingTest.java
@@ -13,7 +13,7 @@
 import java.util.stream.IntStream;
 
 /**
- * Tests for weighted algorithms
+ * Tests for weighted algorithms.
  */
 @RunWith(Parameterized.class)
 public class WeightedRandomSamplingTest {
@@ -39,20 +39,24 @@ public static Collection<Supplier<WeightedRandomSampling<Integer>>> implementati
     }
 
     /**
-     * Increased weight means more occurrences
+     * Increased weight means more occurrences.
      */
     @Test
     public void correctness() {
         final int[] d = new int[STREAM];
+
         for (int reps = 0; reps < REPS; reps++) {
             final WeightedRandomSampling<Integer> alg = impl.get();
+
             for (int i = 0; i < STREAM; i++) {
                 alg.feed(i, i + 1);
             }
+
             for (int s : alg.sample()) {
                 d[s]++;
             }
         }
+
         for (int i = 0; i < d.length - 1; i++) {
             Assert.assertTrue("WeightedRandomSamplingTest.correctness", d[i] < d[i + 1]);
         }