Skip to content

Conversation

@wonderflow
Copy link
Contributor

Fixes #820

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 18, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2024
@wonderflow wonderflow changed the title support expose metrics for plugins Metrics: support expose metrics for plugins Dec 18, 2024
@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 16.07143% with 47 lines in your changes missing coverage. Please review.

Project coverage is 66.92%. Comparing base (0474e1d) to head (96b4b3d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/pkg/filtermanager/api_impl.go 3.22% 30 Missing ⚠️
api/pkg/filtermanager/config.go 31.57% 12 Missing and 1 partial ⚠️
api/pkg/plugins/plugins.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #827       +/-   ##
===========================================
- Coverage   85.44%   66.92%   -18.52%     
===========================================
  Files         141      101       -40     
  Lines        8407     4828     -3579     
===========================================
- Hits         7183     3231     -3952     
- Misses        969     1444      +475     
+ Partials      255      153      -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test the behavior, we can define a new API like

func (dp *DataPlane) SetLogLevel(loggerName string, level string) error {
to fetches the metrics.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2024
@wonderflow wonderflow force-pushed the metrics branch 2 times, most recently from c1c2719 to 9f45d1f Compare December 19, 2024 13:42
@wonderflow
Copy link
Contributor Author

FYI, this PR currently blocked by: envoyproxy/envoy#37808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no stale size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support expose envoy metrics for plugins

2 participants