Support TLS #8
Merged
Support TLS #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doujiang24
reviewed
Jun 12, 2023
doujiang24
approved these changes
Jun 13, 2023
| @@ -0,0 +1,79 @@ | |||
| static_resources: | |||
There was a problem hiding this comment.
we could consider a go test framework, that may be used in a simple go test command.
in that go test framework, we can start a envoy process with a piece of envoy config, by using Go.
yep, it could be done in a seperate PR.
There was a problem hiding this comment.
OK. I will do it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate issues #6.
what my pull request does
The following options have been added to support LDAP TLS connection:
Set this option to true if the LDAP server should utilize an encrypted TLS connection, either with StartTLS or regular TLS.
When this option is set to true, it instructs the filter to issue a StartTLS request during the initialization of the connection with the LDAP server. If the startTLS setting is enabled, it is crucial to ensure that the tls setting is also enabled.
When TLS is enabled, the connection to the LDAP server is typically verified for security. However, this option allows the filter to proceed and operate even for server connections that may otherwise be considered insecure.
The certificateAuthority option should contain one or more PEM-encoded certificates to use to establish a connection with the LDAP server if the connection uses TLS but that the certificate was signed by a custom Certificate Authority.