Repository navigation
fix: improve dogfood diagnostics and task-aware Light selection - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Before acceptance corrections, four explicitly selected offline synthetic regression cases passed in one invocation (4 case executions, 0.045 seconds). The later category assertions and workflow/status corrections have not been test-executed. The shared trial has 6 case executions remaining; one PR regression run consumes 4, and retries count again.
Independent source review covered request/prompt binding, immutable quarantine writes, current-control guarded reads and managed purge. Parent reviewed the corrected final implementation and committed/pushed head
1773113e996cf9fec5cc47df1dfe6b8e7ffe044c(11 files). Final corrected diff whitespace check passed. Prior documentation check resolved 744 relative file links across 102 Markdown files; it predates the final wording changes. Exact-head PR CI remains pending; its single authorized run executes four synthetic cases plus static syntax/documentation checks. No live-model calls or performance claims.Review boundaries
Quarantine raw/metadata writes share one transaction and immutable per-stage slots. Saved valid replies cannot enter quarantine; a saved rejection blocks corrected submission under the same request. Original request/control/source/parent checks apply on diagnostic reads. Raw bytes and context enter the existing managed content inventory, not the separate no-retry sidecar. Parent reviewed the exact final implementation before this approved review-PR publication. This feature is committed and pushed; merge and live acceptance remain outside this PR publication.
Limits
Quarantine is disabled by default, bounded, immutable and current-control guarded. It covers only eligible returned protocol failures, not transport errors, pre-return oversized output or crashes. A standalone offline quarantine API verifies invalid saved bytes, not provider origin or execution. Opt-in retention does not itself redact hostile/private output; diagnostic access and exports require the host's existing privacy discipline.
Managed purge cannot erase remote/provider copies, caller buffers, exports, backups or stopped-process deadlines. Prompt/context hashes identify bytes, not permission from source text or semantic correctness. No automatic adoption, new retry credit or historical replay is introduced. These offline development checks do not establish live usefulness, general quality or full-cost acceptance. No merge requested.