-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirects for Docs #156
Redirects for Docs #156
Conversation
I think it's probably better to build the docs with the right URLs than all that redirecting. |
@arian we have had in the past both Do you mean we should go back to one of the older way? The good thing with the new system is that |
No, I mean |
See #162 |
@arian updated. It fixes the above cases, plus internal links fixed thru docs compiler. |
The old links were |
@timwienk there are also cases of |
Those did not exist like that in the past, the popular pages linked to pages within |
025b6e7
to
8ff6e27
Compare
@timwienk good point. Corrected and updated. |
afaik this is ready... comments welcome. |
Would be nice to have this merged and uploaded. Anything missing from my part? |
The idea is to redirect these type of links:
core/Module/File
core/docs/Module/File
The idea with this part under is to allow links from "popular pages" in the docs index to be linked to that popular page in the version they were clicked, thus
req.headers.referer