Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for xcm in dancelight #870

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dimartiro
Copy link
Contributor

@dimartiro dimartiro commented Feb 11, 2025

Description

Add benchmarks for xcm generic and fungibles, also changed the fixed weight to use the new calculated weights.

Benchmarks where generated using:

BINARY=target/release/tanssi-relay TEMPLATE_PATH=benchmarking/frame-weight-runtime-template-xcm.hbs OUTPUT_PATH=chains/orchestrator-relays/runtime/dancelight/src/weights/xcm ./tools/benchmarking.sh "pallet_xcm_benchmarks::generic" "*

and

BINARY=target/release/tanssi-relay TEMPLATE_PATH=benchmarking/frame-weight-runtime-template-xcm.hbs OUTPUT_PATH=chains/orchestrator-relays/runtime/dancelight/src/weights/xcm ./tools/benchmarking.sh "pallet_xcm_benchmarks::fungible" "*

Also following the westend implementation

@dimartiro dimartiro self-assigned this Feb 11, 2025
@dimartiro dimartiro added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes and removed D2-notlive PR doesn't change runtime/client code labels Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1416 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2160 KB (no changes) ✅

container chain template simple runtime: 1116 KB (no changes) ✅

container chain template frontier runtime: 1404 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Coverage Report

(master)

@@                       Coverage Diff                        @@
##           master   diego-dancelight-xcm_weights      +/-   ##
================================================================
- Coverage   65.51%                         65.48%   -0.03%     
- Files         343                            342       -1     
+ Lines       59504                          59573      +69     
================================================================
+ Hits        38982                          39006      +24     
+ Misses      20522                          20567      +45     
Files Changed Coverage
/chains/container-chains/runtime-templates/frontier/src/lib.rs 57.65% (-0.05%)
/chains/container-chains/runtime-templates/simple/src/lib.rs 87.25% (-0.02%)
/chains/orchestrator-paras/runtime/dancebox/src/lib.rs 87.98% (-0.01%)
/chains/orchestrator-paras/runtime/flashbox/src/lib.rs 46.80% (-0.05%)

Coverage generated Fri Feb 14 18:44:22 UTC 2025

@dimartiro dimartiro force-pushed the diego-dancelight-xcm_weights branch from 5f1d350 to 8e7fbac Compare February 12, 2025 15:06
@dimartiro dimartiro force-pushed the diego-dancelight-xcm_weights branch from 8e7fbac to cd7157b Compare February 12, 2025 15:07
@dimartiro dimartiro changed the title Add generic weights for xcm in dancelight Add benchmarks for xcm in dancelight Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant