Fix type in BABE smoke test #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
added
B0-silent
dimartiro
approved these changes
Feb 10, 2025
WASM runtime size check:Compared to target branchdancebox runtime: 1416 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2172 KB (no changes) ✅ container chain template simple runtime: 1116 KB (no changes) ✅ container chain template frontier runtime: 1404 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master agustin-fix-smoke-types +/- ##
==========================================================
Coverage 65.97% 65.97% 0.00%
Files 339 339
Lines 59084 59084
==========================================================
Hits 38978 38978
Misses 20106 20106
|
timbrinded
approved these changes
Feb 10, 2025
tmpolaczyk
pushed a commit
that referenced
this pull request
Feb 11, 2025
tmpolaczyk
added a commit
that referenced
this pull request
Feb 11, 2025
This reverts commit a731207.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the new
PolkadotPrimitivesV8ValidatorAppSignaturetype, the oldV7doesn't exist anymore which makes the test to fail.