refactor: 🔧 Update dancelight smoketests #867
Conversation
…ssi into refactor/switch-biome
timbrinded
added
B0-silent
| const sessionIndex = (await api.query.session.currentIndex()).toNumber(); | ||
| const assignmentCollatorKey = ( | ||
| await api.query.tanssiAuthorityAssignment.collatorContainerChain(sessionIndex) | ||
| ).toJSON(); |
There was a problem hiding this comment.
We abuse toJSON because it makes it easier to see the diff when an expect fails. Can you verify that expect(assignmentCollatorKey).toBeNull() shows a nice error message with the assignmentCollatorKey?
There was a problem hiding this comment.
Will check. Problem about using toJSON() is that it casts it to any. What we currently have is that it will show you an error without even having to run the tests
There was a problem hiding this comment.
@timbrinded please check this expect thing
WASM runtime size check:Compared to target branchdancebox runtime: 1416 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2172 KB (+2172 KB) container chain template simple runtime: 1116 KB (-4304 KB) ✅ container chain template frontier runtime: 1404 KB (-5156 KB) ✅ |
Coverage Report@@ Coverage Diff @@
## master feat/add-relay-types-interface +/- ##
=================================================================
Coverage 65.97% 65.97% 0.00%
Files 339 339
Lines 59084 59084
=================================================================
Hits 38978 38978
Misses 20106 20106
|
|
@timbrinded can you merge master back to see the actual changes? |
…dd-relay-types-interface
Updates to the dancelight smoke tests to make more robust.
any, so future inconsistencies get flagged in IDE