Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark script for both benchmark modes #843

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

girazoki
Copy link
Contributor

@girazoki girazoki commented Feb 4, 2025

Right now it had only been fix for the pallet-benchmarking mode

@girazoki girazoki added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1412 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2172 KB (no changes) ✅

container chain template simple runtime: 1116 KB (no changes) ✅

container chain template frontier runtime: 1404 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Coverage Report

(master)

@@                          Coverage Diff                           @@
##           master   girazoki-fix-benchmark-script-again     +/-   ##
======================================================================
  Coverage   66.04%                                66.04%   0.00%     
  Files         335                                   335             
  Lines       58858                                 58858             
======================================================================
  Hits        38869                                 38869             
  Misses      19989                                 19989             
Files Changed Coverage

Coverage generated Tue Feb 4 16:52:01 UTC 2025

@girazoki girazoki added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 4, 2025
@girazoki girazoki added this pull request to the merge queue Feb 4, 2025
Merged via the queue into master with commit fc0f70e Feb 4, 2025
41 checks passed
@girazoki girazoki deleted the girazoki-fix-benchmark-script-again branch February 4, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants